Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that cloud sql provider version is valid #29497

Merged
merged 1 commit into from Feb 13, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Feb 12, 2023

Additional chek on cloud sql version should be done to avoid downloading non-existing binary.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:Google Google (including GCP) related issues labels Feb 12, 2023
@potiuk potiuk force-pushed the verify-cloud-sql-proxy-parameter branch from c599c27 to d723002 Compare February 12, 2023 23:09
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just a few nits

airflow/providers/google/cloud/hooks/cloud_sql.py Outdated Show resolved Hide resolved
tests/providers/google/cloud/hooks/test_cloud_sql.py Outdated Show resolved Hide resolved
tests/providers/google/cloud/hooks/test_cloud_sql.py Outdated Show resolved Hide resolved
Additional chek on cloud sql version should be done to avoid
downloading non-existing binary.
@potiuk potiuk force-pushed the verify-cloud-sql-proxy-parameter branch from addf2e4 to 97ce408 Compare February 13, 2023 10:19
@potiuk potiuk merged commit 5e6f8eb into apache:main Feb 13, 2023
38 checks passed
@potiuk potiuk deleted the verify-cloud-sql-proxy-parameter branch February 13, 2023 14:31
@potiuk
Copy link
Member Author

potiuk commented Feb 13, 2023

Lgtm, just a few nits

Applied. Tests passed. merging.

sirVir pushed a commit to sirVir/airflow that referenced this pull request Mar 14, 2023
Additional chek on cloud sql version should be done to avoid
downloading non-existing binary.
@apache apache deleted a comment from Elonmucks May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:Google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants