Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cloud_sql_binary_path from connection to Hook #29499

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Feb 12, 2023

Specifying cloud_sql_binary_path in connection should never be needed, This is at most property of the Hook (and Operator by transition) if you want to override it, rather than extra in the connection.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:Google Google (including GCP) related issues labels Feb 12, 2023
@potiuk potiuk changed the title Move clouds_sql_binary_path from connection to Hook Move cloud_sql_binary_path from connection to Hook Feb 12, 2023
Specifying cloud_sql_binary_path in connection should never be needed,
This is at most property of the Hook (and Operator by transition) if you
want to override it, rather than extra in the connection.
@potiuk potiuk force-pushed the move-sql-proxy-binary-path-to-hook-params branch from c70cbd2 to cc8b9ab Compare February 12, 2023 23:05
@potiuk potiuk merged commit 32c571e into apache:main Feb 13, 2023
38 checks passed
@potiuk potiuk deleted the move-sql-proxy-binary-path-to-hook-params branch February 13, 2023 23:29
sirVir pushed a commit to sirVir/airflow that referenced this pull request Mar 14, 2023
Specifying cloud_sql_binary_path in connection should never be needed,
This is at most property of the Hook (and Operator by transition) if you
want to override it, rather than extra in the connection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:Google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants