Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make permissions for FileTaskHandler group-writeable and configurable #29506

Merged
merged 1 commit into from Feb 13, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Feb 13, 2023

File Task Handler should apply different permissions to log files generated by Airflow in order to handle impersonation. This change exposes mechanism to bettet control the extend of permissions granted depending on individual preferences of the users. Default permissions are set to "group-writeable" allowing for impersonation use case, but it can be more relaxed or more limited by configuration.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

File Task Handler should apply different permissions to log files
generated by Airflow in order to handle impersonation. This change
exposes mechanism to bettet control the extend of permissions granted
depending on individual preferences of the users. Default permissions
are set to "group-writeable" allowing for impersonation use case, but
it can be more relaxed or more limited by configuration.
@potiuk potiuk marked this pull request as ready for review February 13, 2023 14:44
@potiuk potiuk requested a review from ashb as a code owner February 13, 2023 14:44
@potiuk potiuk merged commit 18347d3 into apache:main Feb 13, 2023
54 checks passed
@potiuk potiuk deleted the change-permissions-of-logs branch February 13, 2023 16:15
@potiuk potiuk added this to the Airflow 2.5.2 milestone Feb 13, 2023
@pierrejeambrun pierrejeambrun added the type:misc/internal Changelog: Misc/Internal changes (CI, Tests, Style related changes like Pylint, MyPy) label Feb 27, 2023
@pierrejeambrun pierrejeambrun added type:improvement Changelog: Improvements and removed type:misc/internal Changelog: Misc/Internal changes (CI, Tests, Style related changes like Pylint, MyPy) labels Mar 8, 2023
sirVir pushed a commit to sirVir/airflow that referenced this pull request Mar 14, 2023
…apache#29506)

File Task Handler should apply different permissions to log files
generated by Airflow in order to handle impersonation. This change
exposes mechanism to bettet control the extend of permissions granted
depending on individual preferences of the users. Default permissions
are set to "group-writeable" allowing for impersonation use case, but
it can be more relaxed or more limited by configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants