Allows to choose SSL context for IMAP provider #33108
Merged
+150
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change add two options to choose from when SSL IMAP connection is created: * default - for balance between compatibility and security * none - in case compatibility with existing infrastructure is preferred The fallback is: * The Airflow "email", "ssl_context" * "default"
potiuk
force-pushed
the
add-imap-provider-ssl-context-option
branch
from
2e8f658
to
b20d631
Compare
potiuk
added
the
full tests needed
ephraimbuddy
approved these changes
Aug 4, 2023
Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
|
All good. Random failures /flaky tests only. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 4, 2023
The previous changes apache#33070 and apache#33108 added configuration parameters to allow "ssl_context" to be configured "per installation of airflow". The ssl_context extras allow to override the system-wide setting with extras configured per-connection.
44 tasks
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 8, 2023
* Allows to choose SSL context for IMAP provider This change add two options to choose from when SSL IMAP connection is created: * default - for balance between compatibility and security * none - in case compatibility with existing infrastructure is preferred The fallback is: * The Airflow "email", "ssl_context" * "default" Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> (cherry picked from commit 52ca7bf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change add two options to choose from when SSL IMAP connection is created:
The fallback is:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.