From e1df403a90711211436ad4d4442d4e60f61cdc24 Mon Sep 17 00:00:00 2001 From: Hussein Awala Date: Sat, 9 Sep 2023 22:36:07 +0200 Subject: [PATCH] Replace try/except/pass by contextlib.suppress in ElasticSearch provider --- airflow/providers/elasticsearch/log/es_task_handler.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/airflow/providers/elasticsearch/log/es_task_handler.py b/airflow/providers/elasticsearch/log/es_task_handler.py index 944fe88cf981e..e227ca85cabd6 100644 --- a/airflow/providers/elasticsearch/log/es_task_handler.py +++ b/airflow/providers/elasticsearch/log/es_task_handler.py @@ -17,6 +17,7 @@ # under the License. from __future__ import annotations +import contextlib import inspect import logging import sys @@ -322,12 +323,10 @@ def _format_msg(self, log_line): # Using formatter._style.format makes it future proof i.e. # if we change the formatter style from '%' to '{' or '$', this will still work if self.json_format: - try: + with contextlib.suppress(Exception): return self.formatter._style.format( logging.makeLogRecord({**LOG_LINE_DEFAULTS, **log_line.to_dict()}) ) - except Exception: - pass # Just a safe-guard to preserve backwards-compatibility return log_line.message