Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[AIRFLOW-161] New redirect route and extra links #3533
Make sure you have checked all steps below.
This PR is an attempt to finish the work started in #2657
With this change different operators would be able to customize the
In order to be able to display the link on UI, and not have the backend do the external routing, I had to setup the endpoint to
Update the modal box to make a AJAX call for link resolutions
Note: A lot of the changes here are duplicating UI work between
I should also mention here that at Lyft, we've had this running in production for half a year, and it's been really useful so far.
I will also make a follow up PR with some improvements we've made to extra_links, allowing the user to specify extra_links as plugins that will apply to all operators. We use this feature to link to some logging tools we use (Kibana)
@@ Coverage Diff @@ ## master #3533 +/- ## =========================================== - Coverage 74.65% 11.02% -63.64% =========================================== Files 430 430 Lines 27974 28033 +59 =========================================== - Hits 20884 3090 -17794 - Misses 7090 24943 +17853
referenced this pull request
Jun 25, 2018
2 times, most recently
Jun 26, 2018
astahlman left a comment
A couple of points to consider:
After trying to do it statically, I ran into the same issue @msumit did with the tree view. The tree view of a DAG loads up a bunch of dates at once, that complicates the logic decently. I think the AJAX calls is actually a simpler solution for the moment.