New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-3068] Remove deprecated imports #3906

Merged
merged 1 commit into from Sep 16, 2018

Conversation

Projects
None yet
2 participants
@Fokko
Copy link
Contributor

Fokko commented Sep 16, 2018

Remove the deprecated way of importing in preparation of Airflow 2.0

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-3068] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff
@r39132

This comment has been minimized.

Copy link
Contributor

r39132 commented Sep 16, 2018

+1

@r39132 r39132 merged commit 0e5eee8 into apache:master Sep 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ckljohn added a commit to ckljohn/incubator-airflow that referenced this pull request Nov 7, 2018

@ckljohn ckljohn referenced this pull request Nov 7, 2018

Merged

[AIRFLOW-3308] Fix plugins import #4153

4 of 6 tasks complete

ckljohn added a commit to ckljohn/incubator-airflow that referenced this pull request Nov 7, 2018

ckljohn added a commit to ckljohn/incubator-airflow that referenced this pull request Nov 7, 2018

Fokko added a commit that referenced this pull request Nov 20, 2018

tmiller-msft added a commit to cse-airflow/incubator-airflow that referenced this pull request Nov 27, 2018

elizabethhalper added a commit to cse-airflow/incubator-airflow that referenced this pull request Dec 7, 2018

aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment