New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-2918] Remove unused imports #3932

Merged
merged 1 commit into from Sep 21, 2018

Conversation

Projects
None yet
4 participants
@Fokko
Copy link
Contributor

Fokko commented Sep 21, 2018

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff
@kaxil

This comment has been minimized.

Copy link
Contributor

kaxil commented Sep 21, 2018

Below tests are failing

======================================================================
23) ERROR: test_with_requirements_pinned (tests.operators.test_virtualenv_operator.TestPythonVirtualenvOperator)
----------------------------------------------------------------------
   Traceback (most recent call last):
    tests/operators/test_virtualenv_operator.py line 94 in test_with_requirements_pinned
      self.assertNotEqual('0.4', funcsigs.__version__, 'Please update this string if this fails')
   NameError: global name 'funcsigs' is not defined
======================================================================
24) FAIL: test_import_variables_1 (tests.www_rbac.test_views.TestVariableModelView)
----------------------------------------------------------------------
   Traceback (most recent call last):
    tests/www_rbac/test_views.py line 193 in test_import_variables_1
      self.check_content_in_response('1 variable(s) failed to be updated.', resp)
    tests/www_rbac/test_views.py line 89 in check_content_in_response
      self.assertIn(text, resp_html)

@Fokko Fokko force-pushed the Fokko:fd-remove-unused-imports branch 2 times, most recently from f730fc4 to 6d07d1f Sep 21, 2018

@Fokko Fokko force-pushed the Fokko:fd-remove-unused-imports branch from 6d07d1f to 3e3b9cf Sep 21, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 21, 2018

Codecov Report

Merging #3932 into master will decrease coverage by 62.41%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #3932       +/-   ##
===========================================
- Coverage   77.55%   15.13%   -62.42%     
===========================================
  Files         200      200               
  Lines       15969    15965        -4     
===========================================
- Hits        12385     2417     -9968     
- Misses       3584    13548     +9964
Impacted Files Coverage Δ
airflow/utils/helpers.py 27.34% <ø> (-57.39%) ⬇️
airflow/hooks/__init__.py 33.33% <ø> (-9.53%) ⬇️
airflow/www_rbac/api/experimental/endpoints.py 0% <ø> (-91.96%) ⬇️
airflow/www_rbac/validators.py 0% <0%> (-100%) ⬇️
airflow/utils/log/es_task_handler.py 0% <0%> (-100%) ⬇️
airflow/example_dags/subdags/subdag.py 0% <0%> (-100%) ⬇️
airflow/www/validators.py 0% <0%> (-100%) ⬇️
airflow/example_dags/example_docker_operator.py 0% <0%> (-100%) ⬇️
airflow/example_dags/example_subdag_operator.py 0% <0%> (-100%) ⬇️
airflow/api/common/experimental/get_dag_runs.py 0% <0%> (-100%) ⬇️
... and 161 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd85126...3e3b9cf. Read the comment docs.

@r39132

This comment has been minimized.

Copy link
Contributor

r39132 commented Sep 21, 2018

Thx @Fokko

+1

@r39132 r39132 merged commit 491fd74 into apache:master Sep 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Fokko

This comment has been minimized.

Copy link
Contributor

Fokko commented Sep 21, 2018

Thanks @r39132 for merging. I think we should go to full pep8 compliant code.

I noticed that the code coverage dropped dramatically. I think this is because of: https://github.com/apache/incubator-airflow/pull/3932/files#diff-18969c23ddf6770f760e717ae5cca643
But nevertheless this is just artificial way of keeping up the code coverage.

@Fokko Fokko deleted the Fokko:fd-remove-unused-imports branch Sep 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment