Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[AIRFLOW-3106] Validate Postgres connection after saving it #3941
I want to create connection validation when saving a connection. I started with Postgres. Would be nice to know if you agree with the PR, before I implement validation for other connection types.
This PR adds validation for the Postgres connection type. After saving a Connection, it validates by creating a new database connection and executing
@@ Coverage Diff @@ ## master #3941 +/- ## ========================================== - Coverage 75.79% 74.85% -0.95% ========================================== Files 199 200 +1 Lines 15946 15982 +36 ========================================== - Hits 12086 11963 -123 - Misses 3860 4019 +159
left a comment
Awesome suggestion @BasPH
I really like this and makes setting up connections through the UI much easier. 2 points:
Isn't this PR a private case of this?