Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-3161] Fix TaskInstance log link in RBAC UI #3999

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Projects
None yet
2 participants
@chang
Copy link
Contributor

commented Oct 5, 2018

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This change fixes the Log Url link in the new RBAC UI, which was linking to DAG log list rather than task instance logs.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

tests.models:TaskInstanceTest.test_log_url_rbac

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@chang chang changed the title []AIRFLOW-3161] Fix TaskInstance log link in RBAC UI [AIRFLOW-3161] Fix TaskInstance log link in RBAC UI Oct 5, 2018

@r39132 r39132 merged commit 6f83354 into apache:master Oct 5, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@chang chang deleted the chang:fix-rbac-log-link branch Oct 5, 2018

@chang chang restored the chang:fix-rbac-log-link branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.