New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXX] Fix incorrect statement in contributing guide #4104

Merged
merged 1 commit into from Oct 27, 2018

Conversation

Projects
None yet
3 participants
@BasPH
Copy link
Contributor

BasPH commented Oct 27, 2018

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Changed 2 lines in CONTRIBUTING.md.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Changed 2 lines in CONTRIBUTING.md:

  1. Set Python version to 3 in instructions about using Docker for unit testing. The Python world prefers version 3 afaik, so let's promote that version. There's still a note saying both Python 2 & 3 are supported.
  2. Removed incorrect cd statement (pip install must be run from /airflow and the docker run sets the working dir to /airflow, so it's incorrect to then go to /airflow/airflow inside the container).

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

No tests for docs.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes flake8

@BasPH BasPH closed this Oct 27, 2018

@BasPH BasPH reopened this Oct 27, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 27, 2018

Codecov Report

Merging #4104 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4104   +/-   ##
=======================================
  Coverage   76.67%   76.67%           
=======================================
  Files         199      199           
  Lines       16186    16186           
=======================================
  Hits        12411    12411           
  Misses       3775     3775

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da842d2...1741297. Read the comment docs.

@Fokko

Fokko approved these changes Oct 27, 2018

Copy link
Contributor

Fokko left a comment

Awesome, thanks @BasPH!

@Fokko Fokko merged commit 7fc182e into apache:master Oct 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

kaxil added a commit to kaxil/incubator-airflow that referenced this pull request Nov 6, 2018

wyndhblb added a commit to ASAPPinc/incubator-airflow that referenced this pull request Nov 9, 2018

aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment