New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXX] Remove spots in all Airflow logos #4206

Merged
merged 1 commit into from Nov 17, 2018

Conversation

Projects
None yet
3 participants
@BasPH
Copy link
Contributor

BasPH commented Nov 17, 2018

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Turns out I wasn't very consistent in my PR removing the spot in the Airflow logo (#4065). The file size increased by 22KB and there are 4 more Airflow logo images containing the same spot.

I this PR, I drastically reduced image size by exporting with Photoshop, removing all metadata, and with 8-bit and RGB colors. This was already the case in all Airflow logos, but turns out my Photoshop stored with 24-bit colors by default. The end result:

airflow/www/static/pin_large.jpg | 400kb -> 316kb
airflow/www/static/pin_large.png | 358kb -> 104kb
airflow/www_rbac/static/pin_large.jpg | 400kb -> 316kb
airflow/www_rbac/static/pin_large.png | 358kb -> 104kb
docs/img/pin_large.png | 381kb -> 104kb

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

No tests required.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes flake8
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 17, 2018

Codecov Report

Merging #4206 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4206   +/-   ##
======================================
  Coverage    77.7%   77.7%           
======================================
  Files         199     199           
  Lines       16315   16315           
======================================
  Hits        12677   12677           
  Misses       3638    3638

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c82ecb...b8c1859. Read the comment docs.

@ashb ashb merged commit fa69f22 into apache:master Nov 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

tmiller-msft added a commit to cse-airflow/incubator-airflow that referenced this pull request Nov 27, 2018

elizabethhalper added a commit to cse-airflow/incubator-airflow that referenced this pull request Dec 7, 2018

aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment