New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXX] Replace airflow with apache-airflow #4246

Merged
merged 1 commit into from Nov 27, 2018

Conversation

Projects
None yet
4 participants
@Fokko
Copy link
Contributor

Fokko commented Nov 27, 2018

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes flake8
@ashb

ashb approved these changes Nov 27, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 27, 2018

Codecov Report

Merging #4246 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4246   +/-   ##
=======================================
  Coverage   77.82%   77.82%           
=======================================
  Files         201      201           
  Lines       16367    16367           
=======================================
  Hits        12738    12738           
  Misses       3629     3629

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8c0b63...7e2d8b6. Read the comment docs.

@kaxil kaxil merged commit 2fd409d into apache:master Nov 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

elizabethhalper added a commit to cse-airflow/incubator-airflow that referenced this pull request Dec 7, 2018

aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment