Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-4501] pymysql pendulum fix #5190

Merged
merged 1 commit into from Jun 6, 2019

Conversation

@nazo
Copy link
Contributor

commented Apr 26, 2019

@nazo nazo force-pushed the nazo:master branch to 8052ab0 Apr 26, 2019

@zhongjiajie

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

Please add jira ticket due to you change code. @nazo

@codecov-io

This comment has been minimized.

Copy link

commented Apr 26, 2019

Codecov Report

Merging #5190 into master will decrease coverage by 0.2%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5190      +/-   ##
=========================================
- Coverage   78.91%   78.7%   -0.21%     
=========================================
  Files         474     472       -2     
  Lines       30046   30088      +42     
=========================================
- Hits        23710   23682      -28     
- Misses       6336    6406      +70
Impacted Files Coverage Δ
airflow/settings.py 82.83% <33.33%> (-0.11%) ⬇️
airflow/operators/pig_operator.py 0% <0%> (-76.93%) ⬇️
airflow/contrib/operators/dataproc_operator.py 69.83% <0%> (-9.29%) ⬇️
airflow/utils/db.py 90% <0%> (-0.1%) ⬇️
...ib/utils/log/task_handler_with_custom_formatter.py
airflow/example_dags/example_pig_operator.py
airflow/www/views.py 76.22% <0%> (+0.03%) ⬆️
airflow/models/taskinstance.py 92.59% <0%> (+0.17%) ⬆️
airflow/task/task_runner/base_task_runner.py 73.33% <0%> (+0.45%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e10c15...b00cfd1. Read the comment docs.

@XD-DENG

This comment has been minimized.

Copy link
Member

commented May 2, 2019

@nazo it’s a potentially useful change. But as Jiajie suggested above, please create a ticket in JIRA and update your commit/PR here accordingly before we can proceed to review/merge your patch

@nazo nazo changed the title [AIRFLOW-XXX]pymysql pendulum fix [AIRFLOW-4501] pymysql pendulum fix May 11, 2019

@nazo

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

@OmerJog

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

@nazo you'll need to change the commit message from [AIRFLOW-XXX]pymysql pendulum fix to
[AIRFLOW-4501] pymysql pendulum fix converters datetime bug

The logs for releases are generated from the commit message so it's important it will be accurate.

@nazo nazo force-pushed the nazo:master branch from 8052ab0 to b00cfd1 May 13, 2019

@nazo

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

changed commit message.

@ashb ashb merged commit 481a33b into apache:master Jun 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ashb added a commit to ashb/airflow that referenced this pull request Jun 6, 2019

andriisoldatenko added a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019

wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019

dharamsk added a commit to postmates/airflow that referenced this pull request Aug 8, 2019

dharamsk added a commit to postmates/airflow that referenced this pull request Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.