Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5657] Update the upper bound for dill #6334

Merged
merged 2 commits into from Oct 15, 2019
Merged

Conversation

aaltay
Copy link
Member

@aaltay aaltay commented Oct 14, 2019

There is a new 0.3.x version line for dill. This change increases the range to allow using new dill versions. This also makes airflow compatible with beam.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link

Codecov Report

Merging #6334 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6334      +/-   ##
==========================================
- Coverage   80.35%   80.35%   -0.01%     
==========================================
  Files         616      616              
  Lines       35739    35739              
==========================================
- Hits        28719    28717       -2     
- Misses       7020     7022       +2
Impacted Files Coverage Δ
airflow/contrib/operators/ssh_operator.py 82.5% <0%> (-1.25%) ⬇️
airflow/models/taskinstance.py 93.28% <0%> (-0.51%) ⬇️
airflow/utils/dag_processing.py 56.89% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a4c164...ec42c53. Read the comment docs.

Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaltay
Copy link
Member Author

aaltay commented Oct 15, 2019

Thank you for the review @kaxil. I am not familiar with the process. Who could merge this change?

@kaxil kaxil merged commit 76fe5e2 into apache:master Oct 15, 2019
ashb pushed a commit that referenced this pull request Oct 16, 2019
aoen added a commit to aoen/incubator-airflow that referenced this pull request Nov 12, 2019
aoen added a commit to twitter-forks/airflow that referenced this pull request Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants