Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXX] GSoD: Adding 'Create a custom operator' doc #6348

Merged
merged 11 commits into from Oct 25, 2019

Conversation

@KKcorps
Copy link
Contributor

KKcorps commented Oct 16, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release
Kartik
@KKcorps KKcorps changed the title [AIRFLOW-XXX] Adding 'Create a custom operator' doc [AIRFLOW-XXX] GSoD: Adding 'Create a custom operator' doc Oct 16, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 16, 2019

Codecov Report

Merging #6348 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6348      +/-   ##
==========================================
- Coverage   80.08%   79.83%   -0.26%     
==========================================
  Files         616      616              
  Lines       35799    35799              
==========================================
- Hits        28671    28579      -92     
- Misses       7128     7220      +92
Impacted Files Coverage Δ
airflow/operators/mysql_operator.py 0% <0%> (-100%) ⬇️
airflow/operators/mysql_to_hive.py 0% <0%> (-100%) ⬇️
airflow/utils/sqlalchemy.py 86.44% <0%> (-6.78%) ⬇️
airflow/jobs/local_task_job.py 85% <0%> (-5%) ⬇️
airflow/hooks/hive_hooks.py 75.82% <0%> (-1.79%) ⬇️
airflow/models/connection.py 63.88% <0%> (-1.12%) ⬇️
airflow/hooks/dbapi_hook.py 87.28% <0%> (-0.85%) ⬇️
airflow/utils/dag_processing.py 58.4% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b0c9cb...0f141ca. Read the comment docs.

docs/howto/operator/index.rst Outdated Show resolved Hide resolved
KKcorps and others added 4 commits Oct 16, 2019
Co-Authored-By: Kamil Breguła <mik-laj@users.noreply.github.com>
Kartik
@mik-laj mik-laj added the area:docs label Oct 17, 2019
@KKcorps

This comment has been minimized.

Copy link
Contributor Author

KKcorps commented Oct 18, 2019

docs/concepts.rst Outdated Show resolved Hide resolved
docs/howto/operator/custom-operator.rst Outdated Show resolved Hide resolved
docs/howto/operator/custom-operator.rst Outdated Show resolved Hide resolved
docs/howto/operator/custom-operator.rst Outdated Show resolved Hide resolved
docs/howto/operator/custom-operator.rst Outdated Show resolved Hide resolved
docs/howto/operator/custom-operator.rst Outdated Show resolved Hide resolved
docs/howto/operator/custom-operator.rst Outdated Show resolved Hide resolved
docs/howto/operator/custom-operator.rst Outdated Show resolved Hide resolved
docs/howto/operator/index.rst Outdated Show resolved Hide resolved
KKcorps and others added 4 commits Oct 18, 2019
Co-Authored-By: Ash Berlin-Taylor <ash_github@firemirror.com>
Kartik
Kartik
Kartik
docs/howto/custom-operator.rst Outdated Show resolved Hide resolved
docs/howto/custom-operator.rst Outdated Show resolved Hide resolved
docs/howto/custom-operator.rst Outdated Show resolved Hide resolved
docs/howto/custom-operator.rst Outdated Show resolved Hide resolved
Kartik
@frankcash

This comment has been minimized.

Copy link
Contributor

frankcash commented Oct 25, 2019

Definitely looks helpful 👍

@kaxil
kaxil approved these changes Oct 25, 2019
Copy link
Contributor

kaxil left a comment

LGTM. Great job @KKcorps

@kaxil kaxil merged commit c04ee13 into apache:master Oct 25, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
potiuk added a commit to potiuk/airflow that referenced this pull request Oct 26, 2019
potiuk added a commit to potiuk/airflow that referenced this pull request Oct 28, 2019
potiuk added a commit to potiuk/airflow that referenced this pull request Oct 28, 2019
potiuk added a commit to potiuk/airflow that referenced this pull request Oct 28, 2019
potiuk added a commit that referenced this pull request Oct 29, 2019
potiuk added a commit that referenced this pull request Nov 12, 2019
acroos pushed a commit to acroos/airflow that referenced this pull request Nov 18, 2019
VasiliiSurov added a commit to VasiliiSurov/airflow that referenced this pull request Nov 25, 2019
eladkal added a commit to eladkal/airflow that referenced this pull request Dec 2, 2019
kaxil added a commit that referenced this pull request Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.