Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5749] Support the "blocks" component for the Slack operators #6418

Merged
merged 2 commits into from
Oct 26, 2019

Conversation

mingrammer
Copy link
Contributor

@mingrammer mingrammer commented Oct 24, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Slack clients v1.x.x also does support "blocks".

@ashb
Copy link
Member

ashb commented Oct 24, 2019

Change looks good, but test failrues are I think fixed on master. Can you rebase on to latest master?

@mingrammer
Copy link
Contributor Author

@ashb I'm done!

@mingrammer
Copy link
Contributor Author

I found a lint error and fixed it

@feluelle
Copy link
Member

Oh we have two of those #6402

@mingrammer
Copy link
Contributor Author

Oh, I didn't see that :(

Copy link
Member

@feluelle feluelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add [AIRFLOW-4162] to the commit title and a Co-authored-by: to the commit message, because it refers to the same feature. Thanks.

See https://help.github.com/en/github/committing-changes-to-your-project/creating-a-commit-with-multiple-authors

cc @bskim45

@mingrammer
Copy link
Contributor Author

Sure! I'll change the commit message.

@mingrammer
Copy link
Contributor Author

mingrammer commented Oct 26, 2019

@feluelle @bskim45 I changed the commit message with the existing ticket number and added bskim45 as co-author.

@feluelle
Copy link
Member

feluelle commented Oct 26, 2019

Thank you guys for being so collaborative :) I can merge it when ✔️

@codecov-io
Copy link

codecov-io commented Oct 26, 2019

Codecov Report

Merging #6418 into master will decrease coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6418      +/-   ##
==========================================
- Coverage   84.25%   83.91%   -0.35%     
==========================================
  Files         627      627              
  Lines       36525    36529       +4     
==========================================
- Hits        30775    30653     -122     
- Misses       5750     5876     +126
Impacted Files Coverage Δ
airflow/operators/slack_operator.py 100% <100%> (ø) ⬆️
...irflow/contrib/operators/slack_webhook_operator.py 91.3% <100%> (+0.39%) ⬆️
...ow/contrib/example_dags/example_qubole_operator.py 32.5% <0%> (-57.5%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/kube_client.py 33.33% <0%> (-41.67%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 70.14% <0%> (-28.36%) ⬇️
airflow/gcp/example_dags/example_dataflow.py 93.33% <0%> (-6.67%) ⬇️
airflow/models/baseoperator.py 95.93% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf4a34...e67b460. Read the comment docs.

@feluelle feluelle merged commit 3cc816d into apache:master Oct 26, 2019
@mingrammer mingrammer deleted the airflow-5749 branch October 26, 2019 18:12
kaxil pushed a commit that referenced this pull request Dec 14, 2019
…lack operators (#6418)

Co-authored-by: bskim45 <bskim45@gmail.com>
kaxil pushed a commit that referenced this pull request Dec 14, 2019
…lack operators (#6418)

Co-authored-by: bskim45 <bskim45@gmail.com>
kaxil pushed a commit that referenced this pull request Dec 17, 2019
…lack operators (#6418)

Co-authored-by: bskim45 <bskim45@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants