[AIRFLOW-5758] Support the custom cursor classes for the PostgreSQL hook#6432
Merged
Conversation
Contributor
Author
|
There is a failed test case. |
feluelle
reviewed
Oct 26, 2019
Codecov Report
@@ Coverage Diff @@
## master #6432 +/- ##
==========================================
- Coverage 84.26% 83.65% -0.61%
==========================================
Files 627 635 +8
Lines 36506 36670 +164
==========================================
- Hits 30760 30678 -82
- Misses 5746 5992 +246
Continue to review full report at Codecov.
|
feluelle
approved these changes
Oct 26, 2019
Member
|
Hey @mingrammer do you also want to add a note to the class docstring about the functionality you added (like the notes about ssl and AWS IAM auth.) ? This way users will have it easier to use it. |
Contributor
Author
|
Sure, I'll do! |
Contributor
Author
|
Done. |
Contributor
Author
|
Some azure-dependant test cases are failing due to azure library changes. |
Member
|
I see. Let's wait until #6486 is merged and then I rerun the failed ones. |
Member
|
Thanks @mingrammer :) |
kaxil
pushed a commit
that referenced
this pull request
Dec 17, 2019
ashb
pushed a commit
that referenced
this pull request
Dec 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation