Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5758] Support the custom cursor classes for the PostgreSQL hook #6432

Merged
merged 6 commits into from Nov 2, 2019

Conversation

mingrammer
Copy link
Contributor

@mingrammer mingrammer commented Oct 25, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5758
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mingrammer
Copy link
Contributor Author

mingrammer commented Oct 26, 2019

There is a failed test case.

16) FAIL: test_wait_for_response_running (tests.gcp.hooks.test_kubernetes_engine.TestGKEClusterHook)
----------------------------------------------------------------------
   Traceback (most recent call last):
    /usr/local/lib/python3.6/unittest/mock.py line 1183 in patched
      return func(*args, **keywargs)
    tests/gcp/hooks/test_kubernetes_engine.py line 309 in test_wait_for_response_running
      self.assertEqual(time_mock.call_count, 3)
   AssertionError: 11202 != 3
   -------------------- >> begin captured logging << --------------------
   airflow.gcp.hooks.kubernetes_engine.GKEClusterHook: INFO: Waiting for OPERATION_NAME <Mock name='mock.name' id='140681303781840'>
   --------------------- >> end captured logging << ---------------------

airflow/hooks/postgres_hook.py Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Oct 26, 2019

Codecov Report

Merging #6432 into master will decrease coverage by 0.6%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6432      +/-   ##
==========================================
- Coverage   84.26%   83.65%   -0.61%     
==========================================
  Files         627      635       +8     
  Lines       36506    36670     +164     
==========================================
- Hits        30760    30678      -82     
- Misses       5746     5992     +246
Impacted Files Coverage Δ
airflow/hooks/postgres_hook.py 94.28% <84.61%> (-2.21%) ⬇️
...ow/contrib/example_dags/example_qubole_operator.py 32.5% <0%> (-57.5%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/kube_client.py 33.33% <0%> (-41.67%) ⬇️
airflow/example_dags/example_python_operator.py 63.33% <0%> (-31.12%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 70.14% <0%> (-28.36%) ⬇️
airflow/gcp/example_dags/example_dataflow.py 93.33% <0%> (-6.67%) ⬇️
airflow/utils/dag_processing.py 58.15% <0%> (-0.33%) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e440da...5ef1f92. Read the comment docs.

@feluelle
Copy link
Member

feluelle commented Oct 31, 2019

Hey @mingrammer do you also want to add a note to the class docstring about the functionality you added (like the notes about ssl and AWS IAM auth.) ? This way users will have it easier to use it.

@mingrammer
Copy link
Contributor Author

mingrammer commented Nov 1, 2019

Sure, I'll do!

@mingrammer
Copy link
Contributor Author

mingrammer commented Nov 1, 2019

Done.

@mingrammer
Copy link
Contributor Author

mingrammer commented Nov 1, 2019

Some azure-dependant test cases are failing due to azure library changes.

@feluelle
Copy link
Member

feluelle commented Nov 1, 2019

I see. Let's wait until #6486 is merged and then I rerun the failed ones.

@feluelle
Copy link
Member

feluelle commented Nov 2, 2019

Thanks @mingrammer :)

@feluelle feluelle merged commit 729ba3c into apache:master Nov 2, 2019
1 check passed
@mingrammer mingrammer deleted the airflow-5758 branch Nov 2, 2019
acroos pushed a commit to acroos/airflow that referenced this issue Nov 18, 2019
qianyongyu pushed a commit to qianyongyu/airflow that referenced this issue Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants