Fix for duplicate Rookie authors selection in Top Rookie PR list#65914
Merged
Conversation
potiuk
approved these changes
Apr 27, 2026
Contributor
Backport successfully created: v3-2-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
github-actions Bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 27, 2026
(cherry picked from commit eac6ee6) Co-authored-by: Srabasti Banerjee <srabasti_b@ymail.com>
aws-airflow-bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 27, 2026
(cherry picked from commit eac6ee6) Co-authored-by: Srabasti Banerjee <srabasti_b@ymail.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 27, 2026
(cherry picked from commit eac6ee6) Co-authored-by: Srabasti Banerjee <srabasti_b@ymail.com>
potiuk
pushed a commit
that referenced
this pull request
May 1, 2026
(cherry picked from commit eac6ee6) Co-authored-by: Srabasti Banerjee <srabasti_b@ymail.com>
potiuk
pushed a commit
that referenced
this pull request
May 2, 2026
(cherry picked from commit eac6ee6) Co-authored-by: Srabasti Banerjee <srabasti_b@ymail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix to ensure duplicate authors do not show up in Top Rookie PR list.
Was generative AI tooling used to co-author this PR?
Sonnet 4.6 Adaptive
Fix duplicate rookie authors in Top Rookie PR list
Problem
When running the script in
--rookiemode, the same author can appear multiple times in the Top N list. For example, in the April 2026 run, X appeared at both position 10 and 11:This is unfair to other rookie contributors — a single prolific rookie can dominate the list, crowding out other genuine newcomers.
Root Cause
The final selection in
main()usesheapq.nlargeston scores with no per-author constraint:Fix
In
--rookiemode, enforce a maximum of 1 PR per author when selecting the Top N, while leaving the non-rookie path completely unchanged:Why this is safe
elsebranch is identical to the originalheapq.nlargest- non-rookie mode is completely unchangedpr_stat.authorconsistently usespr_data["author"]["login"](GitHub login) throughout the script — no mismatch risksetandsortedare Python builtinsmain()is replaced — no other logic is touchedImpact
Each rookie author can appear at most once in the Top N list, ensuring the award highlights a broader set of new contributors rather than being dominated by a single active newcomer.
I have tested local, works fine before and after fix runs. Local pre-commit checks do not give errors related to this PR.