Skip to content

[v3-2-test] Fix for duplicate rookies (#65914) #65919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 1 commit into from
+15 −1
Closed

[v3-2-test] Fix for duplicate rookies (#65914) #65919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion dev/stats/get_important_pr_candidates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1044,7 +1044,21 @@ def main(
# Format date range for display
date_range_str = f"{date_start.strftime('%Y-%m-%d')} to {date_end.strftime('%Y-%m-%d')}"
console.print(f"\n[bold green]🏆 Top {top_number} PRs ({date_range_str}):[/bold green]\n")
top_final = heapq.nlargest(top_number, scores.items(), key=lambda x: x[1])

if rookie:
# One PR per author to ensure fair representation of different rookies
seen_authors: set[str] = set()
selected = []
for pr_num, score in sorted(scores.items(), key=lambda x: x[1], reverse=True):
pr_stat = next((pr for pr in pr_stats if pr.number == pr_num), None)
if pr_stat and pr_stat.author not in seen_authors:
selected.append((pr_num, score))
seen_authors.add(pr_stat.author)
if len(selected) >= top_number:
break
top_final = selected
else:
top_final = heapq.nlargest(top_number, scores.items(), key=lambda x: x[1])

for i, (pr_num, score) in enumerate(top_final, 1):
pr_stat = next((pr for pr in pr_stats if pr.number == pr_num), None)
Expand Down
Loading