Add prek hook enforcing the "example" tag on example DAGs#67354
Merged
jscheffl merged 1 commit intoMay 23, 2026
Conversation
Example DAGs are filtered and grouped by tag across the docs and the UI, but the "example" tag was applied inconsistently. This adds an AST-based prek hook, check-example-dag-tags, that fails when a DAG defined under an example_dags/ folder does not carry the "example" tag, and retags every current violator so the hook passes on a clean checkout. Part of apache#52477 Signed-off-by: André Ahlert <andre@aex.partners>
andreahlert
requested review from
amoghrajesh,
ashb,
bugraoz93,
dheerajturaga,
gopidesupavan,
jason810496,
jscheffl,
kaxil and
potiuk
as code owners
boring-cyborg
Bot
added
area:dev-tools
area:providers
backport-to-v3-2-test
jscheffl
removed
the
backport-to-v3-2-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example DAGs are filtered and grouped by tag across the docs and the UI, but the
exampletag was applied inconsistently. This adds an AST-based prek hook,check-example-dag-tags, that fails when a DAG defined under anexample_dags/folder does not carry theexampletag.The hook resolves
DAG(...),with DAG(...) as ...:,@dag(...)and bare@dagdecorators, and requirestagsto be an inline list/tuple literal containing"example"so it stays statically verifiable. A unit test covering each form lives atscripts/tests/ci/prek/test_check_example_dag_tags.py.Every current violator (112 DAG definitions across 41 files) is retagged in the same commit so the hook passes on a clean checkout.
Part of #52477
Was generative AI tooling used to co-author this PR?