[AIRFLOW-6521]: add project param to bigQuery hook .getSchema method #7118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7118 +/- ##
==========================================
- Coverage 85.17% 84.96% -0.22%
==========================================
Files 683 683
Lines 39155 39155
==========================================
- Hits 33352 33267 -85
- Misses 5803 5888 +85
Continue to review full report at Codecov.
|
mtagle
force-pushed
the
bq_get_schema_project
branch
from
112dd04
to
6dc5ad3
Compare
mtagle
force-pushed
the
bq_get_schema_project
branch
from
6dc5ad3
to
2d38b38
Compare
criccomini
approved these changes
Jan 13, 2020
mik-laj
reviewed
Jan 13, 2020
| @@ -1453,17 +1453,21 @@ def get_dataset_tables(self, dataset_id: str, project_id: Optional[str] = None, | |||
| **optional_params).execute(num_retries=self.num_retries)) | |||
|
|
|||
| @CloudBaseHook.catch_http_exception | |||
| def get_schema(self, dataset_id: str, table_id: str) -> Dict: | |||
There was a problem hiding this comment.
Can you use @CloudBaseHook.fallback_to_default_project_id?
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
…pache#7118) BigQuery hook can now take project_id as a parameter, so that operators may specify project_ids other than the default specified in connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: AIRFLOW-6521
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.