Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated link to official documentation #9629

Merged
merged 1 commit into from Jul 2, 2020
Merged

Conversation

aviralwal
Copy link
Contributor

@aviralwal aviralwal commented Jul 2, 2020

The link to official documentation should point to the documentation page instead of the home page.


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

The link to official documentation should point to the documentation page instead of the home page.
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 2, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://apache-airflow-slack.herokuapp.com/

@turbaszek turbaszek merged commit 37ca8ad into apache:master Jul 2, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 2, 2020

Awesome work, congrats on your first merged pull request!

@aviralwal aviralwal deleted the patch-1 branch July 2, 2020 14:24
kaxil pushed a commit that referenced this pull request Aug 14, 2020
The link to official documentation should point to the documentation page instead of the home page.

(cherry picked from commit 37ca8ad)
@kaxil kaxil added this to the Airflow 1.10.12 milestone Aug 14, 2020
kaxil pushed a commit that referenced this pull request Aug 15, 2020
The link to official documentation should point to the documentation page instead of the home page.

(cherry picked from commit 37ca8ad)
kaxil pushed a commit that referenced this pull request Aug 15, 2020
The link to official documentation should point to the documentation page instead of the home page.

(cherry picked from commit 37ca8ad)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
The link to official documentation should point to the documentation page instead of the home page.

(cherry picked from commit 37ca8ad)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants