Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMBARI-25037] Allow skipping parts of Add Service request validation #2717

Merged
merged 1 commit into from Dec 13, 2018

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Allow skipping the following checks in Add Service request validation:

  • security type in the request must match security type of the cluster
  • Kerberos-related configs (kerberos-env, krb5-conf) should not be modified
  • Kerberos descriptor is provided only for new services being added

By default the existing, strict validation is applied. The new one can be turned on by including "validation": "PERMISSIVE" in the request.

https://issues.apache.org/jira/browse/AMBARI-25037

How was this patch tested?

Tested that:

  • invalid requests are rejected if no validation type is specified
  • invalid request that violates only the above checks is accepted with validation set to permissive
  • invalid request with other violations is still rejected even with validation set to permissive

Tweaked unit test.

Change-Id: Iabc5cac0a81737543c0e0f83b0cdd50da910e049
@adoroszlai adoroszlai self-assigned this Dec 12, 2018
@asfgit
Copy link

asfgit commented Dec 12, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4735/
Test PASSed.

@adoroszlai adoroszlai merged commit 2411ccf into apache:trunk Dec 13, 2018
@adoroszlai adoroszlai deleted the AMBARI-25037_trunk branch December 13, 2018 15:07
vishalsuvagia pushed a commit to vishalsuvagia/ambari that referenced this pull request Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants