Second phase of reconstruct read/write to adapt hive #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar conflict in trino
…ve-2 # Conflicts: # spark/v3.1/spark/src/main/java/com/netease/arctic/spark/ArcticSparkCatalog.java # spark/v3.1/spark/src/main/java/com/netease/arctic/spark/writer/ArcticSparkTaskWriterBuilder.java # spark/v3.1/spark/src/test/java/com/netease/arctic/spark/hive/TestAdaptHiveWriter.java
baiyangtx
approved these changes
Aug 24, 2022
zhoujinsong
reviewed
Aug 25, 2022
| @@ -310,7 +310,9 @@ protected TableMetaStore.Builder getMetaStoreBuilder() { | |||
| storageConfigs.get(CatalogMetaProperties.STORAGE_CONFIGS_KEY_TYPE))) { | |||
| String coreSite = storageConfigs.get(CatalogMetaProperties.STORAGE_CONFIGS_KEY_CORE_SITE); | |||
| String hdfsSite = storageConfigs.get(CatalogMetaProperties.STORAGE_CONFIGS_KEY_HDFS_SITE); | |||
| String hiveSite = storageConfigs.get(CatalogMetaProperties.STORAGE_CONFIGS_KEY_HIVE_SITE); | |||
There was a problem hiding this comment.
Why does base arctic catalog need hive site config?
There was a problem hiding this comment.
Because TableMetaStore generate hive-site location need hive site config
| @@ -106,6 +106,11 @@ | |||
| <version>${iceberg.version}</version> | |||
| <scope>test</scope> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
There was a problem hiding this comment.
Why dose hive moduel need this dependency?
There was a problem hiding this comment.
Because hive client will use mysql jdbc in some case
| @@ -0,0 +1,396 @@ | |||
| /* | |||
zhoujinsong
pushed a commit
that referenced
this pull request
May 31, 2023
* Add flink adapt hive UT, Fix core HiveMetastoreClient bug, Resolved jar conflict in trino * merge spark conflict * fix ut * fix flink ut * fix spark ut * fix trino ut * fix trino ut * fix trino ut * fix flink ut * fix flink ut * Add some annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flink adapt hive UT, Fix core HiveMetastoreClient bug, Resolve jar conflict in trino
link issue #151