Skip to content

Fix the problem of instanceof test always return true. #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix the problem of instanceof test always return true. #41

wants to merge 1 commit into from

Conversation

Kui-Liu
Copy link
Contributor

@Kui-Liu Kui-Liu commented Oct 11, 2017

This instanceof test will always return true because DataType is the superclass of variable nested's class ResourceComparator. The variable nested is not initialized, it would be better to do a null test rather than an instanceof test.
http://findbugs.sourceforge.net/bugDescriptions.html#BC_VACUOUS_INSTANCEOF

This instanceof test will always return true because DataType is the superclass of variable nested's class ResourceComparator. The variable nested is not initialized, it would be better to do a null test rather than an instanceof test.
http://findbugs.sourceforge.net/bugDescriptions.html#BC_VACUOUS_INSTANCEOF
@bodewig
Copy link
Member

bodewig commented Oct 11, 2017

Many thanks, merged.

I'd like to add your name to the contributors list, the contributors,xml file wants a first and a last name and I'm not completely sure what to put where. :-)

@Kui-Liu
Copy link
Contributor Author

Kui-Liu commented Oct 11, 2017

Thanks.
First name: Kui,
Last name: LIU.

@Kui-Liu Kui-Liu closed this Oct 11, 2017
asfgit pushed a commit that referenced this pull request Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants