Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid FileInputStream and FileOutputStream. #77

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@reudismam
Copy link
Contributor

reudismam commented Nov 4, 2018

Avoid FileInputStream and FileOutputStream. These classes override the finalize method. As a result, their objects are only cleaned when the garbage collector performs a sweep. Since Java 7, programmers can use Files.newInputStream and Files.newOutputStream instead of FileInputStream and FileOutputStream to improve performance as recommended in this Java JDK bug-report.

@asfgit

This comment has been minimized.

Copy link

asfgit commented Nov 4, 2018

Can one of the admins verify this patch?

1 similar comment
@asfgit

This comment has been minimized.

Copy link

asfgit commented Nov 4, 2018

Can one of the admins verify this patch?

@bodewig

This comment has been minimized.

Copy link
Member

bodewig commented Nov 4, 2018

this is ok to test

@asfgit

This comment has been minimized.

Copy link

asfgit commented Nov 4, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/89/

@asfgit

This comment has been minimized.

Copy link

asfgit commented Nov 4, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Linux/83/

@asfgit asfgit closed this in 39e5e40 Nov 14, 2018

@bodewig

This comment has been minimized.

Copy link
Member

bodewig commented Nov 14, 2018

Thanks @reudismam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.