fix: change the /version to /apisix/admin/tool/version #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nic-chen
approved these changes
Feb 5, 2021
juzhiyuan
reviewed
Feb 5, 2021
tokers
approved these changes
Feb 5, 2021
|
|
||
| if !strings.HasPrefix(req.URL.Path, "/apisix") { |
There was a problem hiding this comment.
What about swapping these two if block? URI without /apisix can be judged firstly.
There was a problem hiding this comment.
Good capture. I will do this in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
#1408 (comment)
New feature or improvement
change the /version to /apisix/admin/tool/version