Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite e2e test route with plugin orchestration test with ginkgo #1663

Conversation

Jaycean
Copy link
Member

@Jaycean Jaycean commented Mar 24, 2021

Please answer these questions before submitting a pull request


New feature or improvement

  • Rewrite e2e test(rewrite-e2e-test-route-with-plugin-orchestration-test) with ginkgo

@codecov-io
Copy link

codecov-io commented Mar 24, 2021

Codecov Report

Merging #1663 (aa3e6cd) into master (576ba1d) will decrease coverage by 9.76%.
The diff coverage is n/a.

❗ Current head aa3e6cd differs from pull request most recent head 979a11d. Consider uploading reports for the commit 979a11d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1663      +/-   ##
==========================================
- Coverage   72.53%   62.76%   -9.77%     
==========================================
  Files         134      125       -9     
  Lines        5738     5272     -466     
  Branches      666      666              
==========================================
- Hits         4162     3309     -853     
- Misses       1333     1775     +442     
+ Partials      243      188      -55     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test 51.81% <ø> (ø)
frontend-e2e-test 73.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/utils/version.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/filter/request_id.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/core/entity/entity.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/core/store/storehub.go 0.00% <0.00%> (-74.77%) ⬇️
api/internal/filter/cors.go 0.00% <0.00%> (-66.67%) ⬇️
api/internal/filter/schema.go 0.00% <0.00%> (-55.47%) ⬇️
api/internal/utils/consts/api_error.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/handler/data_loader/route_import.go 27.41% <0.00%> (-37.50%) ⬇️
api/internal/handler/handler.go 42.59% <0.00%> (-35.19%) ⬇️
api/internal/handler/schema/schema.go 66.66% <0.00%> (-33.34%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 576ba1d...979a11d. Read the comment docs.

Copy link
Member

@imjoey imjoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks.

func TestRoute_With_Plugin_Orchestration(t *testing.T) {
bytes, err := ioutil.ReadFile("../testdata/dag-conf.json")
assert.Nil(t, err)
var _ = ginkgo.Describe("route with plugin orchestration", func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test cases here only check the admin API, but not concerned about the data use in DP, it's not a closed loop, we may request DP to verify DP's behaviors.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juzhiyuan juzhiyuan merged commit 88f3232 into apache:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants