feature: add array property editor #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juzhiyuan
requested changes
Apr 6, 2020
Member
juzhiyuan
left a comment
juzhiyuan
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
src/lang/en.ts
Outdated
| hashOnTip: 'Select a hash on.' | ||
| }, | ||
| message: { | ||
| cannotAddMore: 'You cannot add more item!' |
Contributor
Author
There was a problem hiding this comment.
I made some changes, but I don't know if that's what you meant.
Member
There was a problem hiding this comment.
We would use items here, because more means many items :)
Contributor
Author
There was a problem hiding this comment.
such as cannotAddMoreItems or moreItems ?
| schemaKeys[key] = [] | ||
| this.arrayPropertiesLength[key] = [...new Array(this.pluginData[key] ? this.pluginData[key].length : schema.properties[key].minItems).keys()] | ||
| break | ||
Contributor
Author
There was a problem hiding this comment.
I don't understand. Can you tell me in more detail? 😁
Member
There was a problem hiding this comment.
Please remove the blank line in switch statement :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add feature #166
Make array properties available for graphical editing
Add translation content