Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use data value directly in tests #1838

Closed
wants to merge 10 commits into from
Closed

chore: use data value directly in tests #1838

wants to merge 10 commits into from

Conversation

iamayushdas
Copy link
Contributor

@iamayushdas iamayushdas commented May 5, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?
improved test cases for create_and_delete_consumer.spec.js

Related issues

related issue #1774

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented May 5, 2021

Deploy preview for apisix-dashboard ready!

Built with commit 8b3bbbd

https://deploy-preview-1838--apisix-dashboard.netlify.app

@iamayushdas
Copy link
Contributor Author

@guoqqqi have a look

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's it, LGTM

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2021

Codecov Report

Merging #1838 (23750f6) into master (16dfb4d) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1838      +/-   ##
==========================================
+ Coverage   72.07%   72.10%   +0.02%     
==========================================
  Files         125      125              
  Lines        2944     2947       +3     
  Branches      710      711       +1     
==========================================
+ Hits         2122     2125       +3     
  Misses        822      822              
Flag Coverage Δ
frontend-e2e-test 72.10% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/Route/Create.tsx 90.99% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16dfb4d...23750f6. Read the comment docs.

@juzhiyuan
Copy link
Member

@iamayushdas Hi, please update other test cases in other PRs. One PR with one Testcase.

@iamayushdas
Copy link
Contributor Author

@iamayushdas Hi, please update other test cases in other PRs. One PR with one Testcase.

okay sure

Comment on lines 29 to 30
notification: '.ant-notification-notice-message',
notificationCloseIcon: '.ant-notification-close-icon',
host: "#host",
alert: "[role=alert]"
}
Copy link
Member

@guoqqqi guoqqqi May 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
notification: '.ant-notification-notice-message',
notificationCloseIcon: '.ant-notification-close-icon',
host: "#host",
alert: "[role=alert]"
}
notification: '.ant-notification-notice-message',
notificationCloseIcon: '.ant-notification-close-icon',
host: '#host',
alert: '[role=alert]'
}

It is best to use both single and double quotation marks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Why there have spaces?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my problem. I didn't see the space gap clearly when commenting on my phone……

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@iamayushdas
Copy link
Contributor Author

Ok @guoqqqi

@iamayushdas iamayushdas closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants