-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use data value directly in tests #1838
Conversation
Deploy preview for apisix-dashboard ready! Built with commit 8b3bbbd |
@guoqqqi have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's it, LGTM
Codecov Report
@@ Coverage Diff @@
## master #1838 +/- ##
==========================================
+ Coverage 72.07% 72.10% +0.02%
==========================================
Files 125 125
Lines 2944 2947 +3
Branches 710 711 +1
==========================================
+ Hits 2122 2125 +3
Misses 822 822
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@iamayushdas Hi, please update other test cases in other PRs. One PR with one Testcase. |
okay sure |
notification: '.ant-notification-notice-message', | ||
notificationCloseIcon: '.ant-notification-close-icon', | ||
host: "#host", | ||
alert: "[role=alert]" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notification: '.ant-notification-notice-message', | |
notificationCloseIcon: '.ant-notification-close-icon', | |
host: "#host", | |
alert: "[role=alert]" | |
} | |
notification: '.ant-notification-notice-message', | |
notificationCloseIcon: '.ant-notification-close-icon', | |
host: '#host', | |
alert: '[role=alert]' | |
} |
It is best to use both single and double quotation marks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my problem. I didn't see the space gap clearly when commenting on my phone……
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Ok @guoqqqi |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
improved test cases for create_and_delete_consumer.spec.js
Related issues
related issue #1774
Checklist: