Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix gitleaks not allowed running #1897

Merged
merged 3 commits into from
May 17, 2021
Merged

Conversation

Yiyiyimu
Copy link
Member

Signed-off-by: yiyiyimu wosoyoung@gmail.com

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

fix gitleaks actions not working due to apache restriction

Related issues

fix #1817

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
@netlify
Copy link

netlify bot commented May 15, 2021

Deploy preview for apisix-dashboard ready!

Built with commit 4f47930

https://deploy-preview-1897--apisix-dashboard.netlify.app

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2021

Codecov Report

Merging #1897 (4f47930) into master (a59e8ef) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1897      +/-   ##
==========================================
- Coverage   69.61%   69.49%   -0.13%     
==========================================
  Files         170      170              
  Lines        6382     6382              
  Branches      745      745              
==========================================
- Hits         4443     4435       -8     
- Misses       1683     1691       +8     
  Partials      256      256              
Flag Coverage Δ
backend-e2e-test 45.21% <ø> (-0.68%) ⬇️
backend-e2e-test-ginkgo 48.73% <ø> (+0.03%) ⬆️
backend-unit-test 52.45% <ø> (ø)
frontend-e2e-test 68.85% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/storage/etcd.go 43.63% <0.00%> (-3.64%) ⬇️
web/src/helpers.tsx 68.85% <0.00%> (-3.28%) ⬇️
...ages/Route/components/DebugViews/DebugDrawView.tsx 77.14% <0.00%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a59e8ef...4f47930. Read the comment docs.

@juzhiyuan
Copy link
Member

Hi @Yiyiyimu, it seems that gitleaks is not shown on the checks list?

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
@Yiyiyimu
Copy link
Member Author

Hi @Yiyiyimu, it seems that gitleaks is not shown on the checks list?

Thanks for remind! Fixed.

@Yiyiyimu Yiyiyimu requested a review from LiteSun May 17, 2021 04:45
@LiteSun LiteSun merged commit 085be97 into apache:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix GitLeaks Action and make it working
6 participants