Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: websocket enable in route #2052

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

Baoyuantop
Copy link
Contributor

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Pass the normal enable_websocket state to the API.

Related issues

fix #1933

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Aug 9, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 0f4e856

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/6111dc8097b02900077de1cb

😎 Browse the preview: https://deploy-preview-2052--apisix-dashboard.netlify.app

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2021

Codecov Report

Merging #2052 (267d3fc) into master (c3ea687) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 267d3fc differs from pull request most recent head 0f4e856. Consider uploading reports for the commit 0f4e856 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2052      +/-   ##
==========================================
+ Coverage   65.88%   65.96%   +0.07%     
==========================================
  Files         121      121              
  Lines        3210     3214       +4     
  Branches      778      781       +3     
==========================================
+ Hits         2115     2120       +5     
+ Misses       1095     1094       -1     
Flag Coverage Δ
frontend-e2e-test 65.96% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/Route/transform.ts 72.72% <ø> (ø)
web/src/app.tsx 100.00% <100.00%> (ø)
web/src/components/Plugin/UI/limit-conn.tsx 100.00% <100.00%> (ø)
web/src/components/Plugin/UI/plugin.tsx 83.33% <100.00%> (ø)
web/src/pages/Route/components/Step1/MetaView.tsx 100.00% <100.00%> (ø)
web/src/helpers.tsx 73.77% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3ea687...0f4e856. Read the comment docs.

Copy link
Contributor

@liuxiran liuxiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juzhiyuan juzhiyuan merged commit b0dfcb4 into apache:master Aug 10, 2021
@Baoyuantop Baoyuantop deleted the fix-websocket-button branch August 10, 2021 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On the front end, the websocket button is useless
5 participants