Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: idle_timeout filed to support set zero value #2296

Merged
merged 4 commits into from
Feb 7, 2022
Merged

fix: idle_timeout filed to support set zero value #2296

merged 4 commits into from
Feb 7, 2022

Conversation

zaunist
Copy link
Contributor

@zaunist zaunist commented Jan 26, 2022

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

A struct filed will be omit which have omitempty tag and be set to default value, so we should use pointer to avoid this problem.

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

fix/resolve #2294

image

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2022

Codecov Report

Merging #2296 (7c00f49) into master (88dadc2) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2296      +/-   ##
==========================================
+ Coverage   69.80%   69.83%   +0.02%     
==========================================
  Files         184      184              
  Lines        7280     7280              
  Branches      830      830              
==========================================
+ Hits         5082     5084       +2     
+ Misses       1902     1900       -2     
  Partials      296      296              
Flag Coverage Δ
backend-e2e-test 37.14% <ø> (ø)
backend-e2e-test-ginkgo 59.42% <ø> (+0.07%) ⬆️
backend-unit-test 49.22% <ø> (ø)
frontend-e2e-test 68.16% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/entity/entity.go 90.90% <ø> (ø)
web/src/helpers.tsx 73.77% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88dadc2...7c00f49. Read the comment docs.

Copy link
Contributor

@starsz starsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test to cover it ?

@zaunist
Copy link
Contributor Author

zaunist commented Jan 26, 2022

Can you add test to cover it ?

Do it latter.

@zaunist zaunist changed the title fix: set default value be omit fix: idle_timeout filed to support set zero value Jan 27, 2022
@zaunist zaunist requested a review from starsz February 6, 2022 14:02
@zaunist
Copy link
Contributor Author

zaunist commented Feb 6, 2022

cc @nic-chen

@juzhiyuan juzhiyuan merged commit 19ccb2b into apache:master Feb 7, 2022
hongbinhsu pushed a commit to fitphp/apix-dashboard that referenced this pull request Feb 23, 2022
* upstream:
  fix: idle_timeout filed to support set zero value (apache#2296)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

idle_timeout will be lost when set to 0 in upstream
6 participants