Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ai plugin uses the wrong key to decide whether to enable #8231

Closed
tzssangglass opened this issue Nov 2, 2022 · 0 comments · Fixed by #8232
Closed

bug: ai plugin uses the wrong key to decide whether to enable #8231

tzssangglass opened this issue Nov 2, 2022 · 0 comments · Fixed by #8232

Comments

@tzssangglass
Copy link
Member

Current Behavior

  1. elseif key == "filter_fun"then
    route_flags["filter_fun"] = true

filter_fun should be filter_func

If filter_func is enabled on the route and other conditions are met for the ai plugin to be enabled, the route matches are cached instead of filter_func.

  1. elseif k == "keepalive" then
    route_up_flags["keepalive"] = true

keepalive should be keepalive_pool

This will cause the keepalive_pool configured in upstream to not take effect, using the default keepalive_pool configuration.

Expected Behavior

null

Error Logs

null

Steps to Reproduce

null

Environment

  • APISIX version (run apisix version): master
  • Operating system (run uname -a):
  • OpenResty / Nginx version (run openresty -V or nginx -V):
  • etcd version, if relevant (run curl http://127.0.0.1:9090/v1/server_info):
  • APISIX Dashboard version, if relevant:
  • Plugin runner version, for issues related to plugin runners:
  • LuaRocks version, for installation issues (run luarocks --version):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant