feature: plugin limit-count support to use redis cluster
#2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nic-chen
reviewed
Oct 14, 2020
gxthrj
approved these changes
Oct 14, 2020
nic-chen
approved these changes
Oct 14, 2020
moonming
requested changes
Oct 14, 2020
moonming
requested changes
Oct 14, 2020
| return setmetatable(self, mt) | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
I don't think copy-paste is good
There was a problem hiding this comment.
in limit-count-redis, the main process of incoming is connect -> process -> keepalive.
but in limit-count-redis-cluster, the main process of incomingis only the process . they were different.
I think it is acceptable for those copied code.
There was a problem hiding this comment.
@moonming I think we can merge this PR now. please take a look at this PR.
moonming
approved these changes
Oct 16, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Support for using redis cluster in limit-count plugin.
fix #638
continue PR: #2340
Pre-submission checklist: