feat: support enable/disable route

[tzssangglass]

fix #2737

What this PR does / why we need it:

Pre-submission checklist:

• Did you explain what problem does this PR solve? Or what new features have been added?
• Have you added corresponding test cases?
• Have you modified the corresponding document?
• Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

[liuxiran]

Thanks for you pr :), just wait for others preview.

[membphis]

nice PR

[membphis]

please fix other similar points

[tzssangglass]

solve above

[tzssangglass]

describe a strange phenomenon, I was using /route_status api and create new routes because I found that using route id 1 and /hello always failed when I ran my local test cases, even through other test cases, like

$prove -I../test-nginx/lib -I./ -r -s t/router/radixtree-host-uri.t         
t/router/radixtree-host-uri.t .. 10/? 
#   Failed test 'TEST 5: hit routes - status code ok'
#   at /usr/local/apisix/../test-nginx/lib/Test/Nginx/Socket.pm line 948.
#          got: '404'
#     expected: '200'

#   Failed test 'TEST 5: hit routes - response_body - response is expected (repeated req 0, req 0)'
#   at /usr/local/apisix/../test-nginx/lib/Test/Nginx/Socket.pm line 1589.
#          got: '{"error_msg":"404 Route Not Found"}
# '
#     expected: 'hello world
# '

#   Failed test 'TEST 6: hit routes - status code ok'
#   at /usr/local/apisix/../test-nginx/lib/Test/Nginx/Socket.pm line 948.
#          got: '404'
#     expected: '200'

#   Failed test 'TEST 6: hit routes - response_body - response is expected (repeated req 0, req 0)'
#   at /usr/local/apisix/../test-nginx/lib/Test/Nginx/Socket.pm line 1589.
#          got: '{"error_msg":"404 Route Not Found"}
# '
#     expected: 'hello world
# '

until I debugged at

apisix/apisix/http/router/radixtree_uri.lua

Line 85 in 9e3c34a

create_radixtree_router(user_routes.values)

when run test, the user_routes.values is nil, but when start apisix, it work.

after find this exception, something change, run the test case is back to normal, and cannot be reproduced. >_<|||

[liuxiran]

is it necessary to add a case：
create a route disabled -> hit route failed-> enable it -> hit route successfully?

[liuxiran]

describe a strange phenomenon, I was using /route_status api and create new routes because I found that using route id 1 and /hello always failed when I ran my local test cases, even through other test cases, like

$prove -I../test-nginx/lib -I./ -r -s t/router/radixtree-host-uri.t         
t/router/radixtree-host-uri.t .. 10/? 
#   Failed test 'TEST 5: hit routes - status code ok'
#   at /usr/local/apisix/../test-nginx/lib/Test/Nginx/Socket.pm line 948.
#          got: '404'
#     expected: '200'

#   Failed test 'TEST 5: hit routes - response_body - response is expected (repeated req 0, req 0)'
#   at /usr/local/apisix/../test-nginx/lib/Test/Nginx/Socket.pm line 1589.
#          got: '{"error_msg":"404 Route Not Found"}
# '
#     expected: 'hello world
# '

#   Failed test 'TEST 6: hit routes - status code ok'
#   at /usr/local/apisix/../test-nginx/lib/Test/Nginx/Socket.pm line 948.
#          got: '404'
#     expected: '200'

#   Failed test 'TEST 6: hit routes - response_body - response is expected (repeated req 0, req 0)'
#   at /usr/local/apisix/../test-nginx/lib/Test/Nginx/Socket.pm line 1589.
#          got: '{"error_msg":"404 Route Not Found"}
# '
#     expected: 'hello world
# '

until I debugged at

apisix/apisix/http/router/radixtree_uri.lua

Line 85 in 9e3c34a

create_radixtree_router(user_routes.values)

when run test, the user_routes.values is nil, but when start apisix, it work.

after find this exception, something change, run the test case is back to normal, and cannot be reproduced. >_<|||

If this magical event happened next, you may cc
@membphis @spacewander @tokers for help😊

[tzssangglass]

is it necessary to add a case：
create a route disabled -> hit route failed-> enable it -> hit route successfully?

test case 1 ~ 4 is testing for uri match, the order is
create a route enable(default) -> hit route successfully-> disable it -> hit route fail

test case 5 ~ 8 is testing for host + uri match, the order is same as above.

I think combining these four steps into one test case would have the same effect.

[membphis]

LGTM, except minor style things

[moonming]

got it Thanks, Ming Wen Twitter: _WenMing 罗泽轩 <notifications@github.com> 于2020年12月5日周六 下午9:25写道：

…

***@***.**** commented on this pull request. ------------------------------ In doc/zh-cn/admin-api.md <#2943 (comment)>: > @@ -76,6 +76,7 @@ |filter_func|可选|匹配规则|用户自定义的过滤函数。可以使用它来实现特殊场景的匹配要求实现。该函数默认接受一个名为 vars 的输入参数，可以用它来获取 Nginx 变量。|function(vars) return vars["arg_name"] == "json" end| |labels |可选 |匹配规则|标识附加属性的键值对|{"version":"v2","build":"16","env":"production"}| |enable_websocket|可选 |辅助| 是否启用 `websocket`(boolean), 缺省 `false`.|| +|status |可选 |辅助| 是否启用此路由, 缺省 `1`。|`1` 表示启用，`0` 表示禁用| |create_time|可选|辅助|单位为秒的 epoch 时间戳，如果不指定则自动创建|1602883670| @moonming <https://github.com/moonming> @nic-chen <https://github.com/nic-chen> The last item 1602883670 is an example, not the default value. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2943 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGJZBK5QQEEOV5BXKKFHUA3STIYDBANCNFSM4ULQ4ZMA> .

[tzssangglass]

thanks to the people at code review, and thanks for the guidance!