feat(debug-mode): add dynamic debug mode #5012
Conversation
|
|
||
| ```yaml | ||
| http: | ||
| dynamic: true # 是否动态开启高级调试模式 |
There was a problem hiding this comment.
Need English comment in English doc
t/debug/dynamic-hook.t
Outdated
| no_root_location(); | ||
| no_shuffle(); | ||
|
|
||
| sub read_file($) { |
There was a problem hiding this comment.
Could we move the read_file into APISIX.pm?
There was a problem hiding this comment.
I prefer to open another PR to do this, which is used in several test cases.
There was a problem hiding this comment.
It is already done in the master branch. Let's merge the master.
apisix/debug.lua
Outdated
| @@ -30,6 +29,7 @@ local setmetatable = setmetatable | |||
| local pcall = pcall | |||
| local ipairs = ipairs | |||
| local unpack = unpack | |||
| local inspect = require "inspect" | |||
There was a problem hiding this comment.
Better to put all require together, and in the form require("ngx.process")
There was a problem hiding this comment.
require("apisix.debug") in init.lua --> require("ngx.process") in debug.lua, will result in error as process.lua:5: unsupported subsystem: stream, see: https://github.com/apache/apisix/runs/3578221555
ngx.process API for stream subsystem is not implemented on openresty 1.19.3.2(but is implemented on 1.19.9.1), so I move require("ngx.process") to function.
There was a problem hiding this comment.
Actually I mean to use require("inspect"), the require("ngx.process") is just an example.
apisix/debug.lua
Outdated
| return true | ||
| end | ||
|
|
||
| function _M.dynamic_enable(api_ctx) |
There was a problem hiding this comment.
This function is called in the request level, but it changes a field at the module level. Look like it will affect other requests?
� Conflicts: � apisix/debug.lua � conf/debug.yaml
t/debug/dynamic-hook.t
Outdated
| no_root_location(); | ||
| no_shuffle(); | ||
|
|
||
| sub read_file($) { |
There was a problem hiding this comment.
It is already done in the master branch. Let's merge the master.
apisix/debug.lua
Outdated
| @@ -30,6 +29,7 @@ local setmetatable = setmetatable | |||
| local pcall = pcall | |||
| local ipairs = ipairs | |||
| local unpack = unpack | |||
| local inspect = require "inspect" | |||
There was a problem hiding this comment.
Actually I mean to use require("inspect"), the require("ngx.process") is just an example.
ignore it. |
What this PR does / why we need it:
Add dynamic debug mode. In scenarios where write file permissions are tightly controlled, advanced debugging mode can be dynamically enabled or disabled via the API to help debug production environments.
Pre-submission checklist: