Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Sep 7, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

Adding isnan scalar function which exists in Rust library.

What changes are included in this PR?

Are there any user-facing changes?

@viirya viirya changed the title Add isnan Add isnan scalar function Sep 7, 2023
@viirya
Copy link
Member Author

viirya commented Sep 7, 2023

CI seems broken: #472

@viirya
Copy link
Member Author

viirya commented Sep 7, 2023

CI should be fixed by #474

scalar_function!(
nanvl,
Nanvl,
"Computes the MD5 hash of the argument, with the result written in hexadecimal."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function description was copied from MD5 previously, I think.

@viirya viirya marked this pull request as draft September 8, 2023 17:04
@viirya
Copy link
Member Author

viirya commented Sep 8, 2023

Ah, this repos still uses 29.0.0.

Changed to draft until this upgrades to latest DataFusion.

@viirya viirya closed this Sep 11, 2023
@viirya
Copy link
Member Author

viirya commented Sep 11, 2023

Close this as there is first time contributor's work #495. This is good first issue so it should be better to let new contributor work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant