Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid iterator materialization in column index lookup #703

Merged
merged 1 commit into from Jul 12, 2021

Conversation

houqp
Copy link
Member

@houqp houqp commented Jul 10, 2021

Rationale for this change

Follow up for #605.

What changes are included in this PR?

Avoid unnecessary iterator materialization based on the suggestion from #605 (comment).

Are there any user-facing changes?

no

@github-actions github-actions bot added the datafusion Changes in the datafusion crate label Jul 10, 2021
Copy link
Member

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @houqp 👍

@alamb alamb merged commit 0a05acf into apache:master Jul 12, 2021
@houqp houqp deleted the qp_iter branch July 12, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants