From 9ff478b102abadc049d4460e64eabea47741c24c Mon Sep 17 00:00:00 2001 From: Curt Hagenlocher Date: Mon, 18 May 2026 15:53:02 -0700 Subject: [PATCH 1/3] Disable bad test --- test/Apache.Arrow.Tests/ArrowReaderVerifier.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/Apache.Arrow.Tests/ArrowReaderVerifier.cs b/test/Apache.Arrow.Tests/ArrowReaderVerifier.cs index b0243382..e5b83e3f 100644 --- a/test/Apache.Arrow.Tests/ArrowReaderVerifier.cs +++ b/test/Apache.Arrow.Tests/ArrowReaderVerifier.cs @@ -362,7 +362,7 @@ private void CompareVariadicArrays(BinaryViewArray actualArray) CompareValidityBuffer(expectedArray.NullCount, _expectedArray.Length, expectedArray.NullBitmapBuffer, expectedArray.Offset, actualArray.NullBitmapBuffer, actualArray.Offset); - Assert.True(expectedArray.Views.SequenceEqual(actualArray.Views)); + // Assert.True(expectedArray.Views.SequenceEqual(actualArray.Views)); for (int i = 0; i < expectedArray.Length; i++) { From 62a96ce69b24c84b84947a9d786325441f26cdce Mon Sep 17 00:00:00 2001 From: Curt Hagenlocher Date: Mon, 18 May 2026 15:56:43 -0700 Subject: [PATCH 2/3] Removed invalid test --- test/Apache.Arrow.Tests/ArrowReaderVerifier.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/Apache.Arrow.Tests/ArrowReaderVerifier.cs b/test/Apache.Arrow.Tests/ArrowReaderVerifier.cs index e5b83e3f..56ed1aa2 100644 --- a/test/Apache.Arrow.Tests/ArrowReaderVerifier.cs +++ b/test/Apache.Arrow.Tests/ArrowReaderVerifier.cs @@ -362,8 +362,6 @@ private void CompareVariadicArrays(BinaryViewArray actualArray) CompareValidityBuffer(expectedArray.NullCount, _expectedArray.Length, expectedArray.NullBitmapBuffer, expectedArray.Offset, actualArray.NullBitmapBuffer, actualArray.Offset); - // Assert.True(expectedArray.Views.SequenceEqual(actualArray.Views)); - for (int i = 0; i < expectedArray.Length; i++) { Assert.True( From 7db4837be4ab149d261f3adc214b08fcfe8105e8 Mon Sep 17 00:00:00 2001 From: Curt Hagenlocher Date: Mon, 18 May 2026 16:22:07 -0700 Subject: [PATCH 3/3] Only enable direct comparison of view buffers when strict comparison is on. --- test/Apache.Arrow.Tests/ArrowReaderVerifier.cs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/Apache.Arrow.Tests/ArrowReaderVerifier.cs b/test/Apache.Arrow.Tests/ArrowReaderVerifier.cs index 56ed1aa2..6a4a325b 100644 --- a/test/Apache.Arrow.Tests/ArrowReaderVerifier.cs +++ b/test/Apache.Arrow.Tests/ArrowReaderVerifier.cs @@ -362,6 +362,11 @@ private void CompareVariadicArrays(BinaryViewArray actualArray) CompareValidityBuffer(expectedArray.NullCount, _expectedArray.Length, expectedArray.NullBitmapBuffer, expectedArray.Offset, actualArray.NullBitmapBuffer, actualArray.Offset); + if (_strictCompare) + { + Assert.True(expectedArray.Views.SequenceEqual(actualArray.Views)); + } + for (int i = 0; i < expectedArray.Length; i++) { Assert.True(