Skip to content

Add support for prepared statement SELECT without parameters #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Add support for prepared statement SELECT without parameters #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/afs.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1309,6 +1309,19 @@ class PreparedStatement {
using WriteFunc = std::add_pointer<arrow::Status(void*)>::type;
arrow::Status select(WriteFunc write, void* writeData)
{
if (parameters_.empty())
{
auto result = SPI_execute(query_.c_str(), false, 0);
if (result <= 0)
{
return arrow::Status::Invalid("failed to run a query: ",
SPI_result_code_string(result),
": ",
query_);
}
return write(writeData);
}

for (const auto& recordBatch : parameters_)
{
SPIExecuteOptions options = {};
Expand Down
16 changes: 16 additions & 0 deletions test/test-flight-sql.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,22 @@ def test_select_prepare
end
end

def test_select_prepare_without_parameters
unless flight_sql_client.respond_to?(:prepare)
omit("red-arrow-flight-sql 14.0.0 or later is required")
end

flight_sql_client.prepare("SELECT 29 AS value", @options) do |statement|
info = statement.execute(@options)
assert_equal(Arrow::Schema.new(value: :int32),
info.get_schema)
endpoint = info.endpoints.first
reader = flight_sql_client.do_get(endpoint.ticket, @options)
assert_equal(Arrow::Table.new(value: Arrow::Int32Array.new([29])),
reader.read_all)
end
end

def test_select_from
run_sql("CREATE TABLE data (value integer)")
run_sql("INSERT INTO data VALUES (1), (-2), (3)")
Expand Down