This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Warn when converting Arrow.Timestamps to Dates.DateTime or ZonedDateT…
…ime (#172) Fixes #166. The problem OP saw in the original issue was that we didn't have a proper `ArrowTypes.fromarrow` method defined for `Dates.DateTime` from `Arrow.Timestamp` with nanosecond precision, which is accurate in one sense because `Dates.DateTime` only supports up to millisecond precision. But better than just erroring when trying to access these values later, we now do the conversion anyway, which may be lossy, and issue a warning about the potentially lossy conversion. If > millisecond precision is needed, then users should pass `convert=false` and operate on the `Arrow.Timestamp` values directly for now.
- Loading branch information
Showing 2 changed files with 22 additions and 5 deletions.