Skip to content
Permalink
Browse files
use actual deprecation (#171)
  • Loading branch information
ericphanson committed Apr 13, 2021
1 parent 6be335c commit 48768102350bc034bc0808be0a06a260bd797426
Showing 2 changed files with 4 additions and 2 deletions.
@@ -373,7 +373,8 @@ function extensiontype(f, meta)
end

function registertype!(juliatype::Type, arrowtype::Type, arrowname::String=string("JuliaLang.", string(juliatype)))
@warn "Arrow.ArrowTypes.registertype! is deprecated in favor of defining `ArrowTypes.ArrowType`, `ArrowTypes.arrowname`, and `ArrowTypes.JuliaType`; see their docs for more information on how to migrate"
msg = "Arrow.ArrowTypes.registertype! is deprecated in favor of defining `ArrowTypes.ArrowType`, `ArrowTypes.arrowname`, and `ArrowTypes.JuliaType`; see their docs for more information on how to migrate"
Base.depwarn(msg, :registertype!)
# TODO: validate that juliatype isn't already default arrow type
JULIA_TO_ARROW_TYPE_MAPPING[juliatype] = (arrowname, arrowtype)
ARROW_TO_JULIA_TYPE_MAPPING[arrowname] = (juliatype, arrowtype)
@@ -372,7 +372,8 @@ function extensiontype(f, meta)
end

function registertype!(juliatype::Type, arrowtype::Type, arrowname::String=string("JuliaLang.", string(juliatype)))
@warn "Arrow.ArrowTypes.registertype! is deprecated in favor of defining `ArrowTypes.ArrowType`, `ArrowTypes.arrowname`, and `ArrowTypes.JuliaType`; see their docs for more information on how to migrate"
msg = "Arrow.ArrowTypes.registertype! is deprecated in favor of defining `ArrowTypes.ArrowType`, `ArrowTypes.arrowname`, and `ArrowTypes.JuliaType`; see their docs for more information on how to migrate"
Base.depwarn(msg, :registertype!)
# TODO: validate that juliatype isn't already default arrow type
JULIA_TO_ARROW_TYPE_MAPPING[juliatype] = (arrowname, arrowtype)
ARROW_TO_JULIA_TYPE_MAPPING[arrowname] = (juliatype, arrowtype)

0 comments on commit 4876810

Please sign in to comment.