Skip to content
Permalink
Browse files
fix ambiguity error (#219)
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
  • Loading branch information
ericphanson and omus committed Aug 3, 2021
1 parent b50d604 commit 551b3c22ad8262182d86e97899c14456bc708f31
Showing 3 changed files with 4 additions and 1 deletion.
@@ -1,7 +1,8 @@
name = "ArrowTypes"
uuid = "31f734f8-188a-4ce0-8406-c8a06bd891cd"
authors = ["quinnj <quinn.jacobd@gmail.com>"]
version = "1.2.0"
version = "1.2.1"


[deps]
UUIDs = "cf7118a7-6976-5b1a-9a39-7adc72f591a4"
@@ -157,6 +157,7 @@ fromarrow(::Type{T}, x::T) where {T} = x
fromarrow(::Type{T}, x...) where {T} = T(x...)
fromarrow(::Type{Union{Missing, T}}, ::Missing) where {T} = missing
fromarrow(::Type{Union{Missing, T}}, x::T) where {T} = x
fromarrow(::Type{Union{Missing, T}}, x::T) where {T<:NamedTuple} = x # ambiguity fix
fromarrow(::Type{Union{Missing, T}}, x) where {T} = fromarrow(T, x)

"NullKind data is actually not physically stored since the data is constant; just the length is needed"
@@ -97,6 +97,7 @@ nt = (id=1, name="bob")
@test ArrowTypes.arrowname(Tuple{}) == ArrowTypes.TUPLE
@test ArrowTypes.JuliaType(Val(ArrowTypes.TUPLE), NamedTuple{(Symbol("1"), Symbol("2")), Tuple{Int, String}}) == Tuple{Int, String}
@test ArrowTypes.fromarrow(Tuple{Int, String}, nt) == (1, "bob")
@test ArrowTypes.fromarrow(Union{Missing, typeof(nt)}, nt) == nt

v = v"1"
v_nt = (major=1, minor=0, patch=0, prerelease=(), build=())

2 comments on commit 551b3c2

@jrevels
Copy link
Contributor

@jrevels jrevels commented on 551b3c2 Aug 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register subdir=src/ArrowTypes

@JuliaRegistrator
Copy link

@JuliaRegistrator JuliaRegistrator commented on 551b3c2 Aug 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/42091

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a ArrowTypes-v1.2.1 -m "<description of version>" 551b3c22ad8262182d86e97899c14456bc708f31
git push origin ArrowTypes-v1.2.1

Please sign in to comment.