Skip to content
Permalink
Browse files
fix accidental invocation of _unsafe_load_tuple (#124)
* fix accidental invocation of _unsafe_load_tuple

* bump Project.toml
  • Loading branch information
jrevels committed Feb 5, 2021
1 parent 6c95ff6 commit a113edd934a1efa667b3ffb3d11b135f746322ab
Showing 3 changed files with 10 additions and 3 deletions.
@@ -1,7 +1,7 @@
name = "Arrow"
uuid = "69666777-d1a9-59fb-9406-91d4454c9d45"
authors = ["quinnj <quinn.jacobd@gmail.com>"]
version = "1.2.3"
version = "1.2.4"

[deps]
BitIntegers = "c3b6d118-76ef-56ca-8cc7-ebb389d030a1"
@@ -38,7 +38,7 @@ Base.size(l::FixedSizeList) = (l.ℓ,)
return missing
else
off = (i - 1) * N
if X === T && isbitstype(Y)
if X === T && isbitstype(Y) && l.data isa Vector{UInt8}
tup = _unsafe_load_tuple(NTuple{N,Y}, l.data, off + 1)
else
tup = ntuple(j->l.data[off + j], N)
@@ -236,12 +236,19 @@ av = Arrow.toarrowvector(CategoricalArray(["a", "bb", "ccc"]))
@test eltype(av) == String

# 121

a = PooledArray(repeat(string.('S', 1:130), inner=5), compress=true)
@test eltype(a.refs) == UInt8
av = Arrow.toarrowvector(a)
@test eltype(av.indices) == Int16

# 123
t = (x = collect(zip(rand(10), rand(10))),)
io = IOBuffer()
Arrow.write(io, t)
seekstart(io)
t2 = Arrow.Table(io)
@test t2.x == t.x

end # @testset "misc"

end

2 comments on commit a113edd

@quinnj
Copy link
Member

@quinnj quinnj commented on a113edd Feb 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

@JuliaRegistrator JuliaRegistrator commented on a113edd Feb 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/29413

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.2.4 -m "<description of version>" a113edd934a1efa667b3ffb3d11b135f746322ab
git push origin v1.2.4

Please sign in to comment.