Skip to content
Permalink
Browse files
Rearrange code by array type (#39)
Code for the various array types was a little all over the place. This
PR consolidates arraytype-specific code into new per-arraytype files.
This also simplifies a few things I noticed reviewing the code: removing
unnecessary utils, stop passing eltypes to arraytype-specific
`arrowvector` methods, reuse `ToList` for `MapType` and get rid of
`ToMap`, and clarify a few of the ArrowTypes interfaces. This should
simplify things a bit for adding support for bitpacked Bool arrays and
supporting CategoricalArrays.
  • Loading branch information
quinnj committed Oct 14, 2020
1 parent e75aeff commit a53da475bedc46f33a59b9609e88cad80b9e58a6
Show file tree
Hide file tree
Showing 16 changed files with 1,376 additions and 1,377 deletions.
@@ -85,7 +85,7 @@ using .Flatbuf; const Meta = Flatbuf
include("arrowtypes.jl")
using .ArrowTypes
include("utils.jl")
include("arraytypes.jl")
include("arraytypes/arraytypes.jl")
include("eltypes.jl")
include("table.jl")
include("write.jl")

0 comments on commit a53da47

Please sign in to comment.