Skip to content
Permalink
Browse files
use _id in warn logging (#225)
  • Loading branch information
ericphanson committed Jul 19, 2021
1 parent f8ebbde commit abed17d3ac7da9d271ed16acb66872993f0e7384
Showing 2 changed files with 3 additions and 3 deletions.
@@ -1,7 +1,7 @@
name = "Arrow"
uuid = "69666777-d1a9-59fb-9406-91d4454c9d45"
authors = ["quinnj <quinn.jacobd@gmail.com>"]
version = "1.6.0"
version = "1.6.1"

[deps]
ArrowTypes = "31f734f8-188a-4ce0-8406-c8a06bd891cd"
@@ -54,7 +54,7 @@ function juliaeltype(f::Meta.Field, meta::Dict{String, String}, convert::Bool)
if JT !== nothing
return f.nullable ? Union{JT, Missing} : JT
else
@warn "unsupported ARROW:extension:name type: \"$typename\", arrow type = $TT" maxlog=1
@warn "unsupported ARROW:extension:name type: \"$typename\", arrow type = $TT" maxlog=1 _id=hash((:juliaeltype, typename, TT))
end
end
return something(TTT, T)
@@ -262,7 +262,7 @@ finaljuliatype(::Type{Timestamp{U, TZ}}) where {U, TZ} = ZonedDateTime
finaljuliatype(::Type{Timestamp{U, nothing}}) where {U} = DateTime

@noinline warntimestamp(U, T) =
@warn "automatically converting Arrow.Timestamp with precision = $U to `$T` which only supports millisecond precision; conversion may be lossy; to avoid converting, pass `Arrow.Table(source; convert=false)" maxlog=1
@warn "automatically converting Arrow.Timestamp with precision = $U to `$T` which only supports millisecond precision; conversion may be lossy; to avoid converting, pass `Arrow.Table(source; convert=false)" maxlog=1 _id=hash((:warntimestamp, U, T))

function Base.convert(::Type{ZonedDateTime}, x::Timestamp{U, TZ}) where {U, TZ}
(U === Meta.TimeUnit.MICROSECOND || U == Meta.TimeUnit.NANOSECOND) && warntimestamp(U, ZonedDateTime)

4 comments on commit abed17d

@omus
Copy link
Contributor

@omus omus commented on abed17d Jul 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

@JuliaRegistrator JuliaRegistrator commented on abed17d Jul 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error while trying to register: Register Failed
@omus, it looks like you are not a publicly listed member/owner in the parent organization (JuliaData).
If you are a member/owner, you will need to change your membership to public. See GitHub Help

@omus
Copy link
Contributor

@omus omus commented on abed17d Jul 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

@JuliaRegistrator JuliaRegistrator commented on abed17d Jul 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/41149

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.6.1 -m "<description of version>" abed17d3ac7da9d271ed16acb66872993f0e7384
git push origin v1.6.1

Please sign in to comment.