From 05986065ce5cdf6a76de646157cc2198f9515028 Mon Sep 17 00:00:00 2001
From: Andrew Lamb <andrew@nerdnetworks.org>
Date: Thu, 28 Jul 2022 15:26:45 -0400
Subject: [PATCH] Clarify the intent of parquet library compilation check, and
 add missing case

---
 .github/workflows/parquet.yml | 35 +++++++++++++++++++++++++++++------
 1 file changed, 29 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/parquet.yml b/.github/workflows/parquet.yml
index 51728c46981..d968b1e6aa5 100644
--- a/.github/workflows/parquet.yml
+++ b/.github/workflows/parquet.yml
@@ -76,18 +76,41 @@ jobs:
         uses: ./.github/actions/setup-builder
         with:
           rust-version: stable
+
+        # Run different tests for the library on its own as well as
+        # all targets to ensure that it still works in the absence of
+        # features that might be enabled by dev-dependencies of other
+        # targets.
+        #
+        # This for each of (library and all-targets), check
+        # 1. compiles with default features
+        # 1. compiles with no default features
+        # 3. compiles with just arrow feature
+        # 3. compiles with all features
       - name: Check compilation
+        run: |
+          cargo check -p parquet
+      - name: Check compilation --no-default-features
+        run: |
+          cargo check -p parquet --no-default-features
+      - name: Check compilation --no-default-features --features arrow
+        run: |
+          cargo check -p parquet --no-default-features --features arrow
+      - name: Check compilation --no-default-features --all-features
+        run: |
+          cargo check -p parquet --all-features
+      - name: Check compilation --all-targets
         run: |
           cargo check -p parquet --all-targets
-      - name: Check compilation --no-default-features --all-targets
+      - name: Check compilation --all-targets --no-default-features
         run: |
-          cargo check -p parquet --no-default-features --all-targets
-      - name: Check compilation --no-default-features --features arrow --all-targets
+          cargo check -p parquet --all-targets --no-default-features
+      - name: Check compilation  --all-targets --no-default-features --features-arrow
         run: |
-          cargo check -p parquet --no-default-features --features arrow --all-targets
-      - name: Check compilation --all-features --all-targets
+          cargo check -p parquet --all-targets --no-default-features --features arrow
+      - name: Check compilation  --all-targets --all-features
         run: |
-          cargo check -p parquet --all-features --all-targets
+          cargo check -p parquet --all-targets --all-features
 
   clippy:
     name: Clippy