Add test for simd, fix warnings

apache · Jul 9, 2021 · 7ef5319 · 7ef5319
1 parent 9970a5d
commit 7ef5319
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
@@ -161,6 +161,12 @@ jobs:
           export CARGO_TARGET_DIR="/github/home/target"
           cd arrow
           cargo test --features "simd"
+      - name: Check new project build with simd features
+        run: |
+          export CARGO_HOME="/github/home/.cargo"
+          export CARGO_TARGET_DIR="/github/home/target"
+          cd arrow/test/dependency/simd
+          cargo check
 
   windows-and-macos:
     name: Test on ${{ matrix.os }} Rust ${{ matrix.rust }}

diff --git a/arrow/src/compute/kernels/comparison.rs b/arrow/src/compute/kernels/comparison.rs
@@ -591,7 +591,7 @@ where
 
                 let bitmask = T::mask_to_u64(&simd_result);
                 let bytes = bitmask.to_le_bytes();
-                &result_slice[0..lanes / 8].copy_from_slice(&bytes[0..lanes / 8]);
+                result_slice[0..lanes / 8].copy_from_slice(&bytes[0..lanes / 8]);
 
                 &mut result_slice[lanes / 8..]
             },
@@ -669,7 +669,7 @@ where
 
             let bitmask = T::mask_to_u64(&simd_result);
             let bytes = bitmask.to_le_bytes();
-            &result_slice[0..lanes / 8].copy_from_slice(&bytes[0..lanes / 8]);
+            result_slice[0..lanes / 8].copy_from_slice(&bytes[0..lanes / 8]);
 
             &mut result_slice[lanes / 8..]
         },

diff --git a/arrow/test/dependency/simd/Cargo.toml b/arrow/test/dependency/simd/Cargo.toml
@@ -24,7 +24,6 @@ edition = "2018"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
-arrow = { path = "../../../../arrow", version = "5.0.0-SNAPSHOT" features = ["simd"]}
-
+arrow = { path = "../../../../arrow", version = "5.0.0-SNAPSHOT", features = ["simd"]}
 
 [workspace]